Review Request 122024: Only install color scheme on toplevel widgets

Martin Gräßlin mgraesslin at
Wed Jan 14 07:26:30 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 14, 2015, 7:26 a.m.)


This change has been marked as submitted.

Review request for KDE Frameworks.

Repository: frameworkintegration


ColorSchemeFilter::installColorScheme sets/deletes an xproperty on the
QWidget to be read by the window manager. The window manager is only
interested in toplevel widgets and doesn't monitor child windows at
all. Thus it is not required to perform this method on non toplevel

The method so far created a native window for each QWidget it operated
on by calling winId. This broke QQuickWidgets when changing the color
scheme as it's not allowed to call QWindow::create on a QQuickWidget.


  src/kstyle/kstyle.cpp b5f7363a27337d706beb73363dc0cffa38762ef4 




Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-frameworks-devel mailing list