Review Request 122024: Only install color scheme on toplevel widgets

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122024/#review73909
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Jan. 13, 2015, 9:49 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122024/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 9:49 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> ColorSchemeFilter::installColorScheme sets/deletes an xproperty on the
> QWidget to be read by the window manager. The window manager is only
> interested in toplevel widgets and doesn't monitor child windows at
> all. Thus it is not required to perform this method on non toplevel
> windows.
> 
> The method so far created a native window for each QWidget it operated
> on by calling winId. This broke QQuickWidgets when changing the color
> scheme as it's not allowed to call QWindow::create on a QQuickWidget.
> 
> 
> Diffs
> -----
> 
>   src/kstyle/kstyle.cpp b5f7363a27337d706beb73363dc0cffa38762ef4 
> 
> Diff: https://git.reviewboard.kde.org/r/122024/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150113/ef2380c3/attachment.html>