Review Request 121952: Make it possible to prevent a toolbar from being hidden

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121952/#review73670
-----------------------------------------------------------


Can't those people that don't want their toolbars to be hidable just not pass ToolBar to setupGUI/createGUI ?


src/ktoggletoolbaraction.cpp
<https://git.reviewboard.kde.org/r/121952/#comment51272>

    weird newline?



src/ktoolbar.h
<https://git.reviewboard.kde.org/r/121952/#comment51271>

    Hidable sounds weird. Anyhow it's KToolbar, so i think having toolBar there is extra, what about isHidable?



src/kxmlgui.xsd
<https://git.reviewboard.kde.org/r/121952/#comment51273>

    "the toolbar the user" sounds weird, did you mean "the user"?


Woul

- Albert Astals Cid


On gen. 9, 2015, 4:27 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121952/
> -----------------------------------------------------------
> 
> (Updated gen. 9, 2015, 4:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 326713
>     https://bugs.kde.org/show_bug.cgi?id=326713
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Adds a "noHide" attribute in the xml format and implements it in the toolbar handler, so we don't get an action to hide some toolbars.
> 
> See related bug for more information. Basically if the application doesnt' have a menu, one can hide the toolbar and then it can't come back.
> 
> 
> Diffs
> -----
> 
>   src/ktoggletoolbaraction.cpp 3539ff3 
>   src/ktoolbar.h 54cc1cd 
>   src/ktoolbar.cpp f79a149 
>   src/ktoolbarhandler.cpp 83c77bd 
>   src/kxmlgui.xsd bca02f1 
> 
> Diff: https://git.reviewboard.kde.org/r/121952/diff/
> 
> 
> Testing
> -------
> 
> Fixes the attached bug, tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150110/3e45ea09/attachment.html>