Review Request 121952: Make it possible to prevent a toolbar from being hidden

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121952/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 4:27 p.m.)


Review request for KDE Frameworks.


Changes
-------

Disable the toolbar action if it's attached to a noHide toolbar.


Bugs: 326713
    https://bugs.kde.org/show_bug.cgi?id=326713


Repository: kxmlgui


Description
-------

Adds a "noHide" attribute in the xml format and implements it in the toolbar handler, so we don't get an action to hide some toolbars.

See related bug for more information. Basically if the application doesnt' have a menu, one can hide the toolbar and then it can't come back.


Diffs (updated)
-----

  src/ktoggletoolbaraction.cpp 3539ff3 
  src/ktoolbar.h 54cc1cd 
  src/ktoolbar.cpp f79a149 
  src/ktoolbarhandler.cpp 83c77bd 
  src/kxmlgui.xsd bca02f1 

Diff: https://git.reviewboard.kde.org/r/121952/diff/


Testing
-------

Fixes the attached bug, tests still pass.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150109/aa6685b9/attachment.html>