Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121953/#review73619
-----------------------------------------------------------


+1 too, maybe you want to pass the metadata as the 2nd parameter?

It doesn't look like it needs to be re-used so it's fine like that as well.

- Aleix Pol Gonzalez


On Jan. 9, 2015, 4:33 p.m., Elias Probst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121953/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 4:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Add filename to KPluginInfo::property() deprecation notice.
> 
> 
> Diffs
> -----
> 
>   src/services/kplugininfo.cpp 98a2aa5c553c8a608afdaf82eee8fec9ca4ca60b 
> 
> Diff: https://git.reviewboard.kde.org/r/121953/diff/
> 
> 
> Testing
> -------
> 
> The deprecation notice for `KPluginInfo::property()` includes now the filename of the originating file, making it easier to update it.
> 
> ```
> Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, use KPluginInfo::pluginName() in "/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_geolocation.so" instead.
> Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, use KPluginInfo::pluginName() in "/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_hotplug.so" instead.
> Calling KPluginInfo::property("X-KDE-PluginInfo-Name") is deprecated, use KPluginInfo::pluginName() in "/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_tasks.so" instead.
> ```
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150109/497407b3/attachment.html>