<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121953/">https://git.reviewboard.kde.org/r/121953/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 too, maybe you want to pass the metadata as the 2nd parameter?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It doesn't look like it needs to be re-used so it's fine like that as well.</p></pre>
<br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On January 9th, 2015, 4:33 p.m. UTC, Elias Probst wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Elias Probst.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2015, 4:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kservice
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add filename to KPluginInfo::property() deprecation notice.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The deprecation notice for <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KPluginInfo::property()</code> includes now the filename of the originating file, making it easier to update it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Calling KPluginInfo<span style="color: #666666">::</span>property(<span style="color: #BA2121">"X-KDE-PluginInfo-Name"</span>) is deprecated, use KPluginInfo<span style="color: #666666">::</span>pluginName() in <span style="color: #BA2121">"/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_geolocation.so"</span> instead.
Calling KPluginInfo<span style="color: #666666">::</span>property(<span style="color: #BA2121">"X-KDE-PluginInfo-Name"</span>) is deprecated, use KPluginInfo<span style="color: #666666">::</span>pluginName() in <span style="color: #BA2121">"/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_hotplug.so"</span> instead.
Calling KPluginInfo<span style="color: #666666">::</span>property(<span style="color: #BA2121">"X-KDE-PluginInfo-Name"</span>) is deprecated, use KPluginInfo<span style="color: #666666">::</span>pluginName() in <span style="color: #BA2121">"/usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_tasks.so"</span> instead.
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/kplugininfo.cpp <span style="color: grey">(98a2aa5c553c8a608afdaf82eee8fec9ca4ca60b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121953/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>