Review Request 121927: Update XCursor settings

[Martin Gräßlin]

> On Jan. 9, 2015, 12:37 p.m., Àlex Fiestas wrote:
> > There is test for this code in kdeplatformtheme_unittest.cpp, do you think it will be possible to test the fallback we have for then the size is -1?
> > 
> > Alsot, maybe checking with XCursorGetTheme that the theme has been applied will be nice, so we make sure we won't loose this in possible future refactors of this code.
> > 
> > Otherwise code looks good!

hey, I just moved the code from kglobalsettings. I have no clue how that code should and could be unit tested and honestly I don't have the time to start writing unit tests for legacy code.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121927/#review73570
-----------------------------------------------------------


On Jan. 9, 2015, 10:18 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121927/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 10:18 a.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas and Eike Hein.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Code taken and adjusted from KGlobalSettings.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db 
>   autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b 
>   src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab 
> 
> Diff: https://git.reviewboard.kde.org/r/121927/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150109/74e35d23/attachment.html>