Review Request 121927: Update XCursor settings
Àlex Fiestas
afiestas at kde.org
Fri Jan 9 11:38:30 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121927/#review73571
-----------------------------------------------------------
src/platformtheme/khintssettings.cpp
<https://git.reviewboard.kde.org/r/121927/#comment51222>
Maybe move this platform specific code to a separate method so IFDEF is smaller? It will help if we need to add more ifdefs in the future.
- Àlex Fiestas
On gen. 9, 2015, 9:18 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121927/
> -----------------------------------------------------------
>
> (Updated gen. 9, 2015, 9:18 a.m.)
>
>
> Review request for KDE Frameworks, Àlex Fiestas and Eike Hein.
>
>
> Repository: frameworkintegration
>
>
> Description
> -------
>
> Code taken and adjusted from KGlobalSettings.
>
>
> Diffs
> -----
>
> src/platformtheme/khintssettings.cpp a477a1078f7d62294abfffc92a77889832b1e0db
> autotests/CMakeLists.txt 00337e775e4e2d3e2d1bb583f4102323f0e5973b
> src/platformtheme/CMakeLists.txt 8a3b1b43d617083730517fe8db0a1e2f543913ab
>
> Diff: https://git.reviewboard.kde.org/r/121927/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150109/74b91970/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list