Review Request 121907: Small code review

Aleix Pol Gonzalez aleixpol at kde.org
Thu Jan 8 11:51:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121907/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 11:51 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: frameworkintegration


Description
-------

Make sure the methods that access the hash are const.
This way we make sure we don't create weird new hash members and we don't need to do a double look-up for the value.


Diffs
-----

  src/platformtheme/khintssettings.h 1d9c1d2 

Diff: https://git.reviewboard.kde.org/r/121907/diff/


Testing
-------

Test still passes, if I don't remove teh ~/.qt-test as discussed in the kde-frameworks list.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150108/66faaafb/attachment.html>


More information about the Kde-frameworks-devel mailing list