Review Request 121907: Small code review

[Aleix Pol Gonzalez]

> On Jan. 8, 2015, 8:29 a.m., Albert Astals Cid wrote:
> > src/platformtheme/khintssettings.h, line 62
> > <https://git.reviewboard.kde.org/r/121907/diff/1/?file=339008#file339008line62>
> >
> >     Make this one const too?

Yes thanks!


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121907/#review73461
-----------------------------------------------------------


On Jan. 8, 2015, 2:08 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121907/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 2:08 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Make sure the methods that access the hash are const.
> This way we make sure we don't create weird new hash members and we don't need to do a double look-up for the value.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/khintssettings.h 1d9c1d2 
> 
> Diff: https://git.reviewboard.kde.org/r/121907/diff/
> 
> 
> Testing
> -------
> 
> Test still passes, if I don't remove teh ~/.qt-test as discussed in the kde-frameworks list.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150108/36815ffe/attachment.html>