Review Request 121908: Fix unit test failure on machines with an empty ~/.qttest.

Matthew Dawson matthew at mjdsystems.ca
Thu Jan 8 08:16:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121908/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 8:16 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: frameworkintegration


Description
-------

To execute the KdePlatformTheme and the KStyle unit tests, a local
kdeglobals test file is required inside the Qt test folders.  If the Qt
test folders don't exist when the test executable starts, this copy will
silently fail, causing further failures.

Now, attempt to pre-create this folder before the copy.  Also abort
the test if the folder creation or the file copy fail, to help diagnose
this issue in the future.


Diffs
-----

  autotests/kdeplatformtheme_unittest.cpp cc17ef6e3f3c0db3c4597105b32320f0aeb52b0f 
  autotests/kstyle_unittest.cpp e0e0046100acc195b1a3c36bbbe67e5861d7b7ee 

Diff: https://git.reviewboard.kde.org/r/121908/diff/


Testing
-------

Executing the test suite locally now succeeds.


Thanks,

Matthew Dawson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150108/29f2e34b/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list