Review Request 121903: Clean up how we deal with debug input

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121903/#review73399
-----------------------------------------------------------


+1 to removing the custom handler


startkde/startkde.cmake
<https://git.reviewboard.kde.org/r/121903/#comment51110>

    Order of evaluation:
        QtProject/qtlogging.ini
        setFilterRules()
        QT_LOGGING_CONF
        QT_LOGGING_RULES
    
    This will block all of the other methods from working. I don't think we can really do that.
    
    I'd prefer making a template qtlogging.ini if the file doesn't exist; as that still allows apps to override libs on/off if they prefer and allows people to set a logging_conf if they prefer.


- David Edmundson


On Jan. 7, 2015, 5:57 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121903/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2015, 5:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> At the moment we are having a very ugly setting in plasmashell called "--shut-up" to filter output by default. This patch tries to address that by defining, in startkde, by default:
> ```QT_LOGGING_RULES="*.debug=false"```
> 
> This filters out all q*Debug calls. It's better because it won't filter warnings so they can be read from .xsession-errors in case we need to debug things (at the moment it was useless because we were filtering everything) and it will also work for other processes, which can also come in handy.
> 
> Developers might want to ```unset QT_LOGGING_RULES``` after this
> 
> 
> Diffs
> -----
> 
>   shell/main.cpp 005f908 
>   startkde/startkde.cmake 046543e 
> 
> Diff: https://git.reviewboard.kde.org/r/121903/diff/
> 
> 
> Testing
> -------
> 
> Log out + log in seemed to work after the changes, I'm unsure how to test, especially the startkde part. Should be quite straightforward though.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150107/7a74d47b/attachment.html>