Review Request 121903: Clean up how we deal with debug input

Aleix Pol Gonzalez aleixpol at kde.org
Wed Jan 7 17:57:54 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121903/
-----------------------------------------------------------

Review request for KDE Frameworks and Plasma.


Repository: plasma-workspace


Description
-------

At the moment we are having a very ugly setting in plasmashell called "--shut-up" to filter output by default. This patch tries to address that by defining, in startkde, by default:
```QT_LOGGING_RULES="*.debug=false"```

This filters out all q*Debug calls. It's better because it won't filter warnings so they can be read from .xsession-errors in case we need to debug things (at the moment it was useless because we were filtering everything) and it will also work for other processes, which can also come in handy.

Developers might want to ```unset QT_LOGGING_RULES``` after this


Diffs
-----

  shell/main.cpp 005f908 
  startkde/startkde.cmake 046543e 

Diff: https://git.reviewboard.kde.org/r/121903/diff/


Testing
-------

Log out + log in seemed to work after the changes, I'm unsure how to test, especially the startkde part. Should be quite straightforward though.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150107/b7aeaa30/attachment.html>


More information about the Kde-frameworks-devel mailing list