Review Request 121850: Port KRunner to categorized logging
Milian Wolff
mail at milianw.de
Mon Jan 5 11:53:28 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121850/#review73136
-----------------------------------------------------------
Ship it!
src/declarative/krunner_debug.h
<https://git.reviewboard.kde.org/r/121850/#comment50858>
fixup name, also in .cpp
- Milian Wolff
On Jan. 5, 2015, 9:45 a.m., Luca Beltrame wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121850/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2015, 9:45 a.m.)
>
>
> Review request for KDE Frameworks, Plasma and Vishesh Handa.
>
>
> Bugs: 342491
> https://bugs.kde.org/show_bug.cgi?id=342491
>
>
> Repository: krunner
>
>
> Description
> -------
>
> This ports KRunner to categorized logging to reduce verbosity.
>
> Notice: I've duplicated the code in declarative/ because it has separate CMakeLists. I can fix it (suggestions welcome on how to do it) or just remove the categorized logging there if not needed.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 71d7409
> src/abstractrunner.cpp 9693ed8
> src/declarative/CMakeLists.txt 5d73e10
> src/declarative/krunner_debug.h PRE-CREATION
> src/declarative/krunner_debug.cpp PRE-CREATION
> src/declarative/runnermodel.cpp 4fd2f2b
> src/declarative/runnermodelplugin.cpp 33539a9
> src/krunner_debug.h PRE-CREATION
> src/krunner_debug.cpp PRE-CREATION
> src/querymatch.cpp d22f4f0
> src/runnercontext.cpp c7070ac
> src/runnerjobs.cpp b090821
> src/runnermanager.cpp 0cf8120
>
> Diff: https://git.reviewboard.kde.org/r/121850/diff/
>
>
> Testing
> -------
>
> Compiles.
>
>
> Thanks,
>
> Luca Beltrame
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150105/1fabcebe/attachment.html>
More information about the Kde-frameworks-devel
mailing list