<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121850/">https://git.reviewboard.kde.org/r/121850/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121850/diff/3/?file=338360#file338360line2" style="color: black; font-weight: bold; text-decoration: underline;">src/declarative/krunner_debug.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> Copyright (C) 2014 Laurent Montel <montel@kde.org></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">fixup name, also in .cpp</p></pre>
</div>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On January 5th, 2015, 9:45 a.m. UTC, Luca Beltrame wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Plasma and Vishesh Handa.</div>
<div>By Luca Beltrame.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2015, 9:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=342491">342491</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
krunner
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This ports KRunner to categorized logging to reduce verbosity. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Notice: I've duplicated the code in declarative/ because it has separate CMakeLists. I can fix it (suggestions welcome on how to do it) or just remove the categorized logging there if not needed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(71d7409)</span></li>
<li>src/abstractrunner.cpp <span style="color: grey">(9693ed8)</span></li>
<li>src/declarative/CMakeLists.txt <span style="color: grey">(5d73e10)</span></li>
<li>src/declarative/krunner_debug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/krunner_debug.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/declarative/runnermodel.cpp <span style="color: grey">(4fd2f2b)</span></li>
<li>src/declarative/runnermodelplugin.cpp <span style="color: grey">(33539a9)</span></li>
<li>src/krunner_debug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/krunner_debug.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/querymatch.cpp <span style="color: grey">(d22f4f0)</span></li>
<li>src/runnercontext.cpp <span style="color: grey">(c7070ac)</span></li>
<li>src/runnerjobs.cpp <span style="color: grey">(b090821)</span></li>
<li>src/runnermanager.cpp <span style="color: grey">(0cf8120)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121850/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>