Review Request 122590: Guard kglobalaccel against QApplication
Kai Uwe Broulik
kde at privat.broulik.de
Thu Feb 26 21:39:03 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122590/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 9:39 nachm.)
Review request for KDE Frameworks, David Edmundson and Martin Gräßlin.
Changes
-------
Add back eventFilter method for BC but let it do nothing
Repository: kglobalaccel
Description
-------
KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up in case there is no QApplication (kscreenlocker_greet). This guards against it.
Diffs (updated)
-----
src/kglobalaccel.h 4a5595f
src/kglobalaccel.cpp d123af4
src/kglobalaccel_p.h b1528dc
Diff: https://git.reviewboard.kde.org/r/122590/diff/
Testing
-------
screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150226/32946b01/attachment.html>
More information about the Kde-frameworks-devel
mailing list