Review Request 122590: Guard kglobalaccel against QApplication

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122590/#review76687
-----------------------------------------------------------



src/kglobalaccel.h
<https://git.reviewboard.kde.org/r/122590/#comment52819>

    from https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++
    
    You cannot:
    
    Remove a virtual function, even if it is a reimplementation of a virtual function from the base class
    
    --
    
    you can make it do nothing though.


- David Edmundson


On Feb. 16, 2015, 12:25 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122590/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 12:25 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up in case there is no QApplication (kscreenlocker_greet). This guards against it.
> 
> 
> Diffs
> -----
> 
>   src/kglobalaccel.h 4a5595f 
>   src/kglobalaccel.cpp df85547 
>   src/kglobalaccel_p.h b1528dc 
> 
> Diff: https://git.reviewboard.kde.org/r/122590/diff/
> 
> 
> Testing
> -------
> 
> screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150226/65e15be2/attachment.html>