Review Request 122706: A KCModule base for QML based KCMs

[Marco Martin]

> On Feb. 24, 2015, 10:09 a.m., Martin Gräßlin wrote:
> > CMakeLists.txt, line 36
> > <https://git.reviewboard.kde.org/r/122706/diff/1/?file=351277#file351277line36>
> >
> >     why KF5Plasma? As far as I can see it doesn't use anything of plasma. Might it be that you meant KPackage?

right, that's from when i ported it from plasma to kpackage, will correct


> On Feb. 24, 2015, 10:09 a.m., Martin Gräßlin wrote:
> > src/kcmoduleqml.cpp, line 73
> > <https://git.reviewboard.kde.org/r/122706/diff/1/?file=351280#file351280line73>
> >
> >     will that work on Wayland?

so far on weston it creates an happy second top level window..
eventually it will have to be ported to qquickWidget, but at the moment it doesn't work (remember, so far all the kcms were ported back to qquickview due to black windows)
on the plus side when if will be ported back to qquickwidget will have to be done just here


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122706/#review76526
-----------------------------------------------------------


On Feb. 24, 2015, 9:29 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122706/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 9:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> this adds a new class called KCModuleQml
> it loads a KPackage with the same plugin name as the kcm, then loads its mainscript qml file from it and puts it in a QQuickView used as main widget of the KCM.
> 
> It supports two ways of loading the qml:
> one is in the showevent of the KCM qwidget, this is compatible with current Systemsettings and kcmshell.
> the other way is with the mainUi accessor/qproperty. This will make possible for a pure QML version of systemsettings (accessing directly mainUi without showing qwidgets)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f3aaf18 
>   src/CMakeLists.txt 10862c6 
>   src/kcmoduleqml.h PRE-CREATION 
>   src/kcmoduleqml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122706/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150224/cea49d1b/attachment.html>