Review Request 122706: A KCModule base for QML based KCMs

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122706/#review76526
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/122706/#comment52689>

    why KF5Plasma? As far as I can see it doesn't use anything of plasma. Might it be that you meant KPackage?



src/kcmoduleqml.cpp
<https://git.reviewboard.kde.org/r/122706/#comment52692>

    nitpick: 0 -> Q_NULLPTR



src/kcmoduleqml.cpp
<https://git.reviewboard.kde.org/r/122706/#comment52691>

    will that work on Wayland?



src/kcmoduleqml.cpp
<https://git.reviewboard.kde.org/r/122706/#comment52690>

    why "plasma"?


- Martin Gräßlin


On Feb. 24, 2015, 10:29 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122706/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 10:29 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> -------
> 
> this adds a new class called KCModuleQml
> it loads a KPackage with the same plugin name as the kcm, then loads its mainscript qml file from it and puts it in a QQuickView used as main widget of the KCM.
> 
> It supports two ways of loading the qml:
> one is in the showevent of the KCM qwidget, this is compatible with current Systemsettings and kcmshell.
> the other way is with the mainUi accessor/qproperty. This will make possible for a pure QML version of systemsettings (accessing directly mainUi without showing qwidgets)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f3aaf18 
>   src/CMakeLists.txt 10862c6 
>   src/kcmoduleqml.h PRE-CREATION 
>   src/kcmoduleqml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122706/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150224/467c35b1/attachment.html>