Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

Àlex Fiestas afiestas at kde.org
Wed Feb 18 20:46:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122613/
-----------------------------------------------------------

(Updated feb. 18, 2015, 8:46 p.m.)


Review request for KDE Frameworks.


Changes
-------

Fixed all the issues.


Repository: kio


Description
-------

The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it.


Diffs (updated)
-----

  autotests/CMakeLists.txt f613c1a 
  autotests/kurlcomboboxtest.h PRE-CREATION 
  autotests/kurlcomboboxtest.cpp PRE-CREATION 
  src/widgets/kurlcombobox.cpp ed5b8a2 

Diff: https://git.reviewboard.kde.org/r/122613/diff/


Testing
-------

Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great.


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150218/0d56abc7/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list