Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122613/#review76245
-----------------------------------------------------------



autotests/kurlcomboboxtest.cpp
<https://git.reviewboard.kde.org/r/122613/#comment52571>

    Name? :)



autotests/kurlcomboboxtest.cpp
<https://git.reviewboard.kde.org/r/122613/#comment52569>

    Never used



autotests/kurlcomboboxtest.cpp
<https://git.reviewboard.kde.org/r/122613/#comment52570>

    Never used



autotests/kurlcomboboxtest.cpp
<https://git.reviewboard.kde.org/r/122613/#comment52572>

    Just create on the stack?


- Kevin Funk


On Feb. 17, 2015, 10:29 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122613/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 10:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> The rest of kio internally is doing this correctly apparently it was only a problem in the GUI part of it.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt f613c1a 
>   autotests/kurlcomboboxtest.h PRE-CREATION 
>   autotests/kurlcomboboxtest.cpp PRE-CREATION 
>   src/widgets/kurlcombobox.cpp ed5b8a2 
> 
> Diff: https://git.reviewboard.kde.org/r/122613/diff/
> 
> 
> Testing
> -------
> 
> Besides the added unit tests, I have used this patch while running a few ups, everything seems to work great.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150218/559177e7/attachment.html>