Review Request 122590: Guard kglobalaccel against QApplication

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122590/#review76116
-----------------------------------------------------------


we should investigate whether the argument for using a widget is still valid. The argument is that destroyed gives a QObject and not a QAction. but this can be easily worked around by connecting to a lambda and capturing the QAction.


src/kglobalaccel.cpp
<https://git.reviewboard.kde.org/r/122590/#comment52517>

    it's totally fine to delete a nullptr. There's no need to guard it


- Martin Gräßlin


On Feb. 16, 2015, 12:45 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122590/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 12:45 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up in case there is no QApplication (kscreenlocker_greet). This guards against it.
> 
> 
> Diffs
> -----
> 
>   src/kglobalaccel.cpp df85547 
>   src/kglobalaccel_p.h b1528dc 
> 
> Diff: https://git.reviewboard.kde.org/r/122590/diff/
> 
> 
> Testing
> -------
> 
> screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150216/835a3430/attachment.html>