Review Request 122590: Guard kglobalaccel against QApplication

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122590/#review76117
-----------------------------------------------------------



src/kglobalaccel.cpp
<https://git.reviewboard.kde.org/r/122590/#comment52518>

    can you do setParent(this); instead of a manual delete?
    
    I know QWidget requires another QWidget in the ctor, but setParent from QObject should allow any.


- David Edmundson


On Feb. 16, 2015, 11:45 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122590/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 11:45 a.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> -------
> 
> KGlobalAccelPrivate uses a QWidget for some magic witchcraft which blows up in case there is no QApplication (kscreenlocker_greet). This guards against it.
> 
> 
> Diffs
> -----
> 
>   src/kglobalaccel.cpp df85547 
>   src/kglobalaccel_p.h b1528dc 
> 
> Diff: https://git.reviewboard.kde.org/r/122590/diff/
> 
> 
> Testing
> -------
> 
> screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150216/a033bf3c/attachment.html>