Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122554/#review75987
-----------------------------------------------------------


As I said in the other review, I believe the user facing strings should use "TTS" rather than "Speech" as TTS or Text-To-Speech is an estabilished abbreviation in the field. Any other opinions on that? Frederik?

As for the config not updating, can you try this:

```
 src/knotifyconfig.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/knotifyconfig.cpp b/src/knotifyconfig.cpp
index af6be92..e9b684b 100644
--- a/src/knotifyconfig.cpp
+++ b/src/knotifyconfig.cpp
@@ -37,6 +37,7 @@ static KSharedConfig::Ptr retrieve_from_cache(const QString &filename, QStandard
 {
     QCache<QString, KSharedConfig::Ptr> &cache = *static_cache;
     if (cache.contains(filename)) {
+        (*cache[filename])->reparseConfiguration();
         return *cache[filename];
     }
 

```


src/knotifyconfigactionswidgetbase.ui
<https://git.reviewboard.kde.org/r/122554/#comment52421>

    Is Jovie still used in QtSpeech? If not, it should be removed from here


- Martin Klapetek


On Feb. 13, 2015, 4:06 a.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122554/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 4:06 a.m.)
> 
> 
> Review request for KDE Frameworks and Frederik Gladhorn.
> 
> 
> Repository: knotifyconfig
> 
> 
> Description
> -------
> 
> Change config from KTTS to Speech.
> If QtSpeech is available when building return true from have_speech static method.
> Otherwise return false.
> Could also add a check to see if there are any backend errors later on.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 
>   src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 
>   src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 
>   src/knotifyconfigactionswidgetbase.ui cbe647b70eb41ba540b7bf6d87f519b3246973a1 
>   src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 
>   src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b 
>   src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 
> 
> Diff: https://git.reviewboard.kde.org/r/122554/diff/
> 
> 
> Testing
> -------
> 
> It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken.
> 
> Something strange here:
> After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case).
> Similarly, after disabling this notification, messages are still spoken until restarting the application.
> I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150213/7aa4f0da/attachment-0001.html>