<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122554/">https://git.reviewboard.kde.org/r/122554/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As I said in the other review, I believe the user facing strings should use "TTS" rather than "Speech" as TTS or Text-To-Speech is an estabilished abbreviation in the field. Any other opinions on that? Frederik?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for the config not updating, can you try this:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> src<span style="color: #666666">/</span>knotifyconfig.cpp <span style="color: #666666">|</span> <span style="color: #666666">1</span> <span style="color: #666666">+</span>
<span style="color: #666666">1</span> file changed, <span style="color: #666666">1</span> insertion(<span style="color: #666666">+</span>)
diff <span style="color: #666666">--</span>git a<span style="color: #666666">/</span>src<span style="color: #666666">/</span>knotifyconfig.cpp b<span style="color: #666666">/</span>src<span style="color: #666666">/</span>knotifyconfig.cpp
index af6be92..e9b684b <span style="color: #666666">100644</span>
<span style="color: #666666">---</span> a<span style="color: #666666">/</span>src<span style="color: #666666">/</span>knotifyconfig.cpp
<span style="color: #666666">+++</span> b<span style="color: #666666">/</span>src<span style="color: #666666">/</span>knotifyconfig.cpp
<span style="border: 1px solid #FF0000">@@</span> <span style="color: #666666">-37</span>,<span style="color: #666666">6</span> <span style="color: #666666">+37</span>,<span style="color: #666666">7</span> <span style="border: 1px solid #FF0000">@@</span> <span style="color: #008000; font-weight: bold">static</span> KSharedConfig<span style="color: #666666">::</span>Ptr retrieve_from_cache(<span style="color: #008000; font-weight: bold">const</span> QString <span style="color: #666666">&</span>filename, QStandard
{
QCache<span style="color: #666666"><</span>QString, KSharedConfig<span style="color: #666666">::</span>Ptr<span style="color: #666666">></span> <span style="color: #666666">&</span>cache <span style="color: #666666">=</span> <span style="color: #666666">*</span>static_cache;
<span style="color: #008000; font-weight: bold">if</span> (cache.contains(filename)) {
<span style="color: #666666">+</span> (<span style="color: #666666">*</span>cache[filename])<span style="color: #666666">-></span>reparseConfiguration();
<span style="color: #008000; font-weight: bold">return</span> <span style="color: #666666">*</span>cache[filename];
}
</pre></div>
</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122554/diff/1/?file=348626#file348626line141" style="color: black; font-weight: bold; text-decoration: underline;">src/knotifyconfigactionswidgetbase.ui</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">141</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <string><qt>Specifies how Jovie should speak the event when received. If you select "Speak custom text", enter the text in the box. You may use the following substitution strings in the text:<dl><dt>%e</dt><dd>Name of the event</dd><dt>%a</dt><dd>Application that sent the event</dd><dt>%m</dt><dd>The message sent by the application</dd></dl></qt></string></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">141</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <string><qt>Specifies how Jovie should speak the event when received. If you select "Speak custom text", enter the text in the box. You may use the following substitution strings in the text:<dl><dt>%e</dt><dd>Name of the event</dd><dt>%a</dt><dd>Application that sent the event</dd><dt>%m</dt><dd>The message sent by the application</dd></dl></qt></string></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is Jovie still used in QtSpeech? If not, it should be removed from here</p></pre>
</div>
</div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On February 13th, 2015, 4:06 a.m. CET, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks and Frederik Gladhorn.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2015, 4:06 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifyconfig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Change config from KTTS to Speech.
If QtSpeech is available when building return true from have_speech static method.
Otherwise return false.
Could also add a check to see if there are any backend errors later on.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds, the config widget shows, the icon for speech is properly showing when that configuration is enabled. Speech from konversation's new message notifications are spoken.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Something strange here:
After enabling this notification, no messages are spoken until restarting the application with the notifications (konversation in my test case).
Similarly, after disabling this notification, messages are still spoken until restarting the application.
I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f5aa0e78d89a4c14c3acfd9384b100e507e30067)</span></li>
<li>src/knotifyconfigactionswidget.h <span style="color: grey">(88b341a909d466b8eaf065c5220ac05f8c963697)</span></li>
<li>src/knotifyconfigactionswidget.cpp <span style="color: grey">(27012e3b803ef0a99d5bafcebea270e2d7419d62)</span></li>
<li>src/knotifyconfigactionswidgetbase.ui <span style="color: grey">(cbe647b70eb41ba540b7bf6d87f519b3246973a1)</span></li>
<li>src/knotifyconfigelement.h <span style="color: grey">(703952d23d1622e4b6214acc52461ea75b480254)</span></li>
<li>src/knotifyconfigelement.cpp <span style="color: grey">(5a1ac57fa5a4139682327d14c55a489450ea956b)</span></li>
<li>src/knotifyeventlist.cpp <span style="color: grey">(148bca7d33c722a4aeecabac45286a5e501c81b3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122554/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>