Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

Aleix Pol Gonzalez aleixpol at kde.org
Wed Feb 11 17:45:26 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122514/
-----------------------------------------------------------

(Updated Feb. 11, 2015, 6:45 p.m.)


Review request for KDE Frameworks, Alex Richardson and David Faure.


Changes
-------

Coding style changes.


Repository: kservice


Description
-------

Currently it checks whether it's a stringlist value according to the servicetype (good) and splits the ','.

What this patch does is to allow plugins to use json lists to specify string list properties. For example:
    "X-KDevelop-Interfaces": [ "IBuildSystemManager", "IProjectFileManager"]

Otherwise I was getting invalid values and nothing worked.
    


Diffs (updated)
-----

  autotests/kplugininfotest.cpp d99b92a 
  src/services/kplugininfo.cpp 572f14b 

Diff: https://git.reviewboard.kde.org/r/122514/diff/


Testing
-------

Builds, tests still pass.

Now KDevelop boots correctly, I tried to add a test, but I don't know where's the service type file for "KService/NSA".


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150211/8d647ed1/attachment.html>


More information about the Kde-frameworks-devel mailing list