Review Request 122514: Make it possible to interpret properties from plugins that expose properties correctly in the json

[Martin Klapetek]

> On Feb. 11, 2015, 4:35 p.m., Kevin Funk wrote:
> > src/services/kplugininfo.cpp, line 574
> > <https://git.reviewboard.kde.org/r/122514/diff/1/?file=348194#file348194line574>
> >
> >     Style: Space after keyword, more below.
> 
> Kevin Funk wrote:
>     Wrong line, sorry. But you know what I mean :)

(and ifs should have {}s and ```QVariant &value``` ;)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122514/#review75866
-----------------------------------------------------------


On Feb. 10, 2015, 6:18 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122514/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 6:18 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Richardson and David Faure.
> 
> 
> Repository: kservice
> 
> 
> Description
> -------
> 
> Currently it checks whether it's a stringlist value according to the servicetype (good) and splits the ','.
> 
> What this patch does is to allow plugins to use json lists to specify string list properties. For example:
>     "X-KDevelop-Interfaces": [ "IBuildSystemManager", "IProjectFileManager"]
> 
> Otherwise I was getting invalid values and nothing worked.
>     
> 
> 
> Diffs
> -----
> 
>   src/services/kplugininfo.cpp 572f14b 
> 
> Diff: https://git.reviewboard.kde.org/r/122514/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests still pass.
> 
> Now KDevelop boots correctly, I tried to add a test, but I don't know where's the service type file for "KService/NSA".
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150211/996d5f84/attachment.html>