Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122413/#review75386
-----------------------------------------------------------

Ship it!


looks better, tough i think the setPaintRect() can still be removed from paint()


src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp
<https://git.reviewboard.kde.org/r/122413/#comment52152>

    i'm not sure setting the panted rect in paint changes anything.
    
    since it's done in setPixmap/setFillmode, that should be enough?


- Marco Martin


On Feb. 3, 2015, 11:41 p.m., Luca Beltrame wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122413/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 11:41 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Like the corresponding properties in QML's Image, this patch introduces paintedWidth and paintedHeight to QPixmapItem, to get information on the size of the pixmap that's actually shown (depending on fillMode), as compared to its actual size.
> 
> This brings QPixmapItem closer to the mode of usage of Image.
> 
> CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 
>   src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 
> 
> Diff: https://git.reviewboard.kde.org/r/122413/diff/
> 
> 
> Testing
> -------
> 
> Builds. 
> 
> 
> Thanks,
> 
> Luca Beltrame
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150204/b9069e67/attachment.html>