Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

Luca Beltrame lbeltrame at kde.org
Tue Feb 3 23:41:22 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122413/
-----------------------------------------------------------

(Updated Feb. 3, 2015, 11:41 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
-------

Add a function setPaintedRect() (could also be updatePaintedRect if you prefer) caching the rect and only updating it when there are actual changes. Made said function a slot so it's invoked after geometryChanged is fired. 


Repository: kdeclarative


Description
-------

Like the corresponding properties in QML's Image, this patch introduces paintedWidth and paintedHeight to QPixmapItem, to get information on the size of the pixmap that's actually shown (depending on fillMode), as compared to its actual size.

This brings QPixmapItem closer to the mode of usage of Image.

CHANGELOG: New properties paintedWidth and paintedHeight added to QPixmapItem


Diffs (updated)
-----

  src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 
  src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 

Diff: https://git.reviewboard.kde.org/r/122413/diff/


Testing
-------

Builds. 


Thanks,

Luca Beltrame

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20150203/2f50cb84/attachment.html>


More information about the Kde-frameworks-devel mailing list