Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

Martin Klapetek martin.klapetek at gmail.com
Tue Dec 29 20:12:37 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126461/
-----------------------------------------------------------

(Updated Dec. 29, 2015, 8:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit f639996becc2fae284d9c83273856dee510b699d by Martin Klapetek to branch master.


Bugs: 356653
    http://bugs.kde.org/show_bug.cgi?id=356653


Repository: plasma-framework


Description
-------

https://git.reviewboard.kde.org/r/126459/ introduced new
flag that allows to skip the grouping of notifications.

This should fix all bugs caused by checking for appName
being "plasma_workspace" which are all default notifications
from any plasmoid.

BUG: 356653

(this also needs to raise the KF5 dep to 5.18 which is
normally done at release time, but in order to use this
now, it needs to be bumped now, otherwise build failures
will ensue)


Diffs
-----

  CMakeLists.txt a27b3ac 
  src/plasma/private/applet_p.cpp 511b451 

Diff: https://git.reviewboard.kde.org/r/126461/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151229/0c9f0ea4/attachment.html>


More information about the Kde-frameworks-devel mailing list