Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126461/#review89861
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Dec. 21, 2015, 8:56 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126461/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 8:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 356653
>     http://bugs.kde.org/show_bug.cgi?id=356653
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> https://git.reviewboard.kde.org/r/126459/ introduced new
> flag that allows to skip the grouping of notifications.
> 
> This should fix all bugs caused by checking for appName
> being "plasma_workspace" which are all default notifications
> from any plasmoid.
> 
> BUG: 356653
> 
> (this also needs to raise the KF5 dep to 5.18 which is
> normally done at release time, but in order to use this
> now, it needs to be bumped now, otherwise build failures
> will ensue)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a27b3ac 
>   src/plasma/private/applet_p.cpp 511b451 
> 
> Diff: https://git.reviewboard.kde.org/r/126461/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151221/06312893/attachment.html>