Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/
-----------------------------------------------------------

(Updated Dez. 28, 2015, 11:14 nachm.)


Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.


Changes
-------

* Drop dedicated "passive" option and instead use the "restarted" parameter passed in by KCrash
* Use KIdleTime to ensure the user doesn't miss the SNI if the app crashed while he was away: think of an hour-long video encoding process, you will have no idea why it's not there anymore when it crashed over night, suggested on my blog

Works fine for applications but Plasma crashes aren't as good anymore with KCrash auto restart. When Plasma crashes a second time I don't get a SNI anymore, sometimes it doesn't even restart. Looks like KCrash doing strange things or giving up prematurely.


Repository: plasma-workspace


Description
-------

This adds a new "--passive" option to DrKonqi where it will only show a StatusNotifierItem rather than bringing up the crash dialog right away.

This can be useful for auto-restarting shell services (like plasmashell, krunner, kded) to improve the perceived quality of the product.

On Windows RT, for example, the guidelines even explicitly say "rather just dump the user on the home screen than telling him something went wrong, so he can just quickly start the app again instead of being annoyed by an error message". On iOS you also just get dropped on the home screen. Windows desktop shows a "Searching for a solution" dialog which was *the* major annoyance when something crashed, rather than the actual crash.

Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc


Diffs (updated)
-----

  drkonqi/CMakeLists.txt eaeaad4 
  drkonqi/main.cpp 7cbaae7 
  drkonqi/statusnotifier.h PRE-CREATION 
  drkonqi/statusnotifier.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126515/diff/


Testing
-------

I crashed plasmashell, it restarted so fast that you didn't even have a black screen inbetween, just the panel restarting. Afterwards I got a SNI which opened DrKonqi when tapped.

The SNI disappears after 1 minute because if you didn't bother to look after it by then, you probably forgot what you did to cause the crash anyway :)


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151228/0bb76144/attachment.html>