Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

[Kai Uwe Broulik]

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote:
> > drkonqi/main.cpp, line 159
> > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159>
> >
> >     and -> or surely?
> >     
> >     both in code and comments.
> 
> Kai Uwe Broulik wrote:
>     The and is correct:
>     
>     - I never want to show the dialog or a notification when we're passive.
>     - I want to show the DrKonqi dialog instead of the KPassivePopup fallback in case no FDO notification service is available
> 
> David Edmundson wrote:
>     Ah, I see. 
>     We've changed the --passive meaning so that this is no longer opt-in.
>     
>     (you did say that in the updated description, but I didn't parse it properly)
>     
>     So in matrix form:
>     
>     passive|notifications running|action
>     -------|--------|-------
>     Yes | Yes | Show SNI and notification
>     Yes | No  | Show SNI and notification
>     No  | Yes | Show SNI
>     No  | No  | Dialog directly
>     
>     ?
> 
> Kai Uwe Broulik wrote:
>     The "passive" is still opt in but I shifted the meaning a bit.
>     
>     Passive now means "don't bother the user" or "don't draw attention", ie. don't show a notification or dialog whatsoever, only SNI. Sorry, I only wrote into the change summary.
>     
>     passive | notifications running | action
>     Yes.... | Yes.................. | Show SNI
>     Yes.... | No................... | Show SNI
>     No..... | Yes.................. | Show SNI and Notification
>     No..... | No................... | Show DrKonqi dialog directly
> 
> David Edmundson wrote:
>     If we go with this, we can effectively just swap the drop the passive flag addition in frameworks and re-use the AutoRestart flag?
>     and assume !AutoRestart == Passive
>     
>     It's how you're describing the usage in your blog post.
>     
>     (would involve Plasma using the existing autorestart rather than doing it's own thing, but I like the idea of that)
> 
> Kai Uwe Broulik wrote:
>     +1 to that
> 
> Marco Martin wrote:
>     hmm, shouldn't be passive when autorestart is enabled AutoRestart == Passive? when nothing is coming back you want the dialog, when the application/shell comes back is when you can ignore it no?

Yes, AutoRestart == Passive
One thing I found is KCrash doesn't bother bringing up DrKonqi on the last restart attempt so you end up with a black screen, if we use KCrash's auto restart functionality.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126515/#review90166
-----------------------------------------------------------


On Dez. 27, 2015, 4:11 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126515/
> -----------------------------------------------------------
> 
> (Updated Dez. 27, 2015, 4:11 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This adds a new "--passive" option to DrKonqi where it will only show a StatusNotifierItem rather than bringing up the crash dialog right away.
> 
> This can be useful for auto-restarting shell services (like plasmashell, krunner, kded) to improve the perceived quality of the product.
> 
> On Windows RT, for example, the guidelines even explicitly say "rather just dump the user on the home screen than telling him something went wrong, so he can just quickly start the app again instead of being annoyed by an error message". On iOS you also just get dropped on the home screen. Windows desktop shows a "Searching for a solution" dialog which was *the* major annoyance when something crashed, rather than the actual crash.
> 
> Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc
> 
> 
> Diffs
> -----
> 
>   drkonqi/CMakeLists.txt eaeaad4 
>   drkonqi/main.cpp 7cbaae7 
>   drkonqi/statusnotifier.h PRE-CREATION 
>   drkonqi/statusnotifier.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126515/diff/
> 
> 
> Testing
> -------
> 
> I crashed plasmashell, it restarted so fast that you didn't even have a black screen inbetween, just the panel restarting. Afterwards I got a SNI which opened DrKonqi when tapped.
> 
> The SNI disappears after 1 minute because if you didn't bother to look after it by then, you probably forgot what you did to cause the crash anyway :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151228/2ee2f32d/attachment.html>