Review Request 126531: Fix some Clazy warnings in kemoticons.
Andrey Cygankov
craftplace.ms at gmail.com
Mon Dec 28 01:48:39 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126531/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 1:48 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
-------
Submitted with commit 6e58d0592b8dc70384223ea2a598f7cf776685be by Aleix Pol on behalf of Andrey Cygankov to branch master.
Repository: kemoticons
Description
-------
Fix some Clazy warnings:
- unneeded heap allocation with QString
- multi-arg non-usage
Diffs
-----
autotests/kemoticontest.cpp df7fb71
autotests/ktexttohtmlplugintest.cpp 0daa222
src/core/kemoticons.cpp 886cc3f
src/providers/adium/adium_emoticons.cpp 31535ab
src/providers/kde/kde_emoticons.cpp 2723e00
src/providers/pidgin/pidgin_emoticons.cpp 92398c4
src/providers/xmpp/xmpp_emoticons.cpp af71ef9
tests/main.cpp d1eab5b
Diff: https://git.reviewboard.kde.org/r/126531/diff/
Testing
-------
Compiling without errors.
Thanks,
Andrey Cygankov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151228/5f37db07/attachment.html>
More information about the Kde-frameworks-devel
mailing list