Review Request 126531: Fix some Clazy warnings in kemoticons.
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Dec 28 01:47:35 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126531/#review90191
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Dec. 27, 2015, 9:08 p.m., Andrey Cygankov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126531/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2015, 9:08 p.m.)
>
>
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
>
>
> Repository: kemoticons
>
>
> Description
> -------
>
> Fix some Clazy warnings:
> - unneeded heap allocation with QString
> - multi-arg non-usage
>
>
> Diffs
> -----
>
> autotests/kemoticontest.cpp df7fb71
> autotests/ktexttohtmlplugintest.cpp 0daa222
> src/core/kemoticons.cpp 886cc3f
> src/providers/adium/adium_emoticons.cpp 31535ab
> src/providers/kde/kde_emoticons.cpp 2723e00
> src/providers/pidgin/pidgin_emoticons.cpp 92398c4
> src/providers/xmpp/xmpp_emoticons.cpp af71ef9
> tests/main.cpp d1eab5b
>
> Diff: https://git.reviewboard.kde.org/r/126531/diff/
>
>
> Testing
> -------
>
> Compiling without errors.
>
>
> Thanks,
>
> Andrey Cygankov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151228/38fb9c9a/attachment.html>
More information about the Kde-frameworks-devel
mailing list