Review Request 126471: Don't emit statusChanged if it hasn't changed

David Edmundson david at davidedmundson.co.uk
Tue Dec 22 17:32:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126471/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 5:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
-------

Submitted with commit 01cd374c8e6396a8f9135338c34dde7570c79e03 by David Edmundson to branch master.


Repository: plasma-framework


Description
-------

For some applets the status is bound to a complex expression that can be
re-evaluated a lot. This ends up causing a lot of unnecassary updates; especially for things in systray.

Found with Aleix's "timertracker" that's in Plasma.


Diffs
-----

  src/plasma/applet.cpp 0b7ef5632c1accb3373aa8f2f57a7880e5f3640d 

Diff: https://git.reviewboard.kde.org/r/126471/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151222/043fbd19/attachment.html>


More information about the Kde-frameworks-devel mailing list