Review Request 126471: Don't emit statusChanged if it hasn't changed

Aleix Pol Gonzalez aleixpol at kde.org
Tue Dec 22 14:18:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126471/#review89920
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Dec. 22, 2015, 3:08 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126471/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 3:08 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> For some applets the status is bound to a complex expression that can be
> re-evaluated a lot. This ends up causing a lot of unnecassary updates; especially for things in systray.
> 
> Found with Aleix's "timertracker" that's in Plasma.
> 
> 
> Diffs
> -----
> 
>   src/plasma/applet.cpp 0b7ef5632c1accb3373aa8f2f57a7880e5f3640d 
> 
> Diff: https://git.reviewboard.kde.org/r/126471/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151222/5c10b7b1/attachment.html>


More information about the Kde-frameworks-devel mailing list