Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

Boudewijn Rempt boud at valdyas.org
Mon Dec 21 13:04:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126230/
-----------------------------------------------------------

(Updated Dec. 21, 2015, 1:04 p.m.)


Status
------

This change has been discarded.


Review request for Build System, KDE Frameworks, Aleix Pol Gonzalez, Chusslove Illich, and Luigi Toscano.


Repository: ki18n


Description
-------

When building ki18n as a dependency framework for shipping with an application, the tools to actually create and manage translations are superfluous. These tools have some big dependencies that are a pain to have around, especially gettext on Windows. This patch makes the requirement for Python and Gettext optional.

This patch checks the BUILD_TESTING variable to see if the autotests should be built, because when we just need the library to build an application we shouldn't waste electicity building the tests (and the Qt5::QML dependency).


Diffs
-----

  CMakeLists.txt 59917fa 
  cmake/KF5I18NMacros.cmake 53ba812 

Diff: https://git.reviewboard.kde.org/r/126230/diff/


Testing
-------


Thanks,

Boudewijn Rempt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151221/3959198c/attachment.html>


More information about the Kde-frameworks-devel mailing list