Review Request 126230: Make python, gettext and Qt5::QML optional for ki18n

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126230/#review89271
-----------------------------------------------------------



cmake/KF5I18NMacros.cmake (lines 55 - 58)
<https://git.reviewboard.kde.org/r/126230/#comment61053>

    If a project uses ki18n_install_ts_files, it will still fail with this change. It just won't be at all obvious to the user *why* it failed: they will get a message about an unknown command, which they may or may not realise is linked to an earlier vague message about Python and Gettext being needed.
    
    If you're going to take this approach, I think you still need to define k18n_install_ts_files in the else() branch, but make it spit out an error about exactly what package(s) are missing.


- Alex Merry


On Dec. 4, 2015, 12:17 a.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126230/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 12:17 a.m.)
> 
> 
> Review request for Build System, KDE Frameworks, Aleix Pol Gonzalez, Chusslove Illich, and Luigi Toscano.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> When building ki18n as a dependency framework for shipping with an application, the tools to actually create and manage translations are superfluous. These tools have some big dependencies that are a pain to have around, especially gettext on Windows. This patch makes the requirement for Python and Gettext optional.
> 
> This patch checks the BUILD_TESTING variable to see if the autotests should be built, because when we just need the library to build an application we shouldn't waste electicity building the tests (and the Qt5::QML dependency).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 59917fa 
>   cmake/KF5I18NMacros.cmake 53ba812 
> 
> Diff: https://git.reviewboard.kde.org/r/126230/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151209/6452b2f9/attachment.html>