Review Request 126330: use Qt defines for portability

Patrick Spendrin ps_ml at gmx.de
Wed Dec 16 08:17:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126330/
-----------------------------------------------------------

(Updated Dez. 16, 2015, 8:17 vorm.)


Review request for KDE Frameworks.


Changes
-------

I oversaw that the generate_export_header was already present, it just wasn't used.


Repository: kdeclarative


Description
-------

far better solution would be to use generate_export_header, if you prefer
that, please let me know.


Diffs (updated)
-----

  src/calendarevents/CMakeLists.txt 6c2aae34556136b70c0f092fc921745d6e313eda 
  src/calendarevents/calendarevents_export.h a4c6f87e62c02a4ed34d0ebff00e0a729357952f 

Diff: https://git.reviewboard.kde.org/r/126330/diff/


Testing
-------

Windows.


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151216/d99d9cc6/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list