Review Request 126330: use Qt defines for portability

David Faure faure at kde.org
Wed Dec 16 08:00:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126330/#review89581
-----------------------------------------------------------


I vote for generate_export_header.

- David Faure


On Dec. 12, 2015, 11:12 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126330/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2015, 11:12 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> far better solution would be to use generate_export_header, if you prefer
> that, please let me know.
> 
> 
> Diffs
> -----
> 
>   src/calendarevents/calendarevents_export.h a4c6f87e62c02a4ed34d0ebff00e0a729357952f 
> 
> Diff: https://git.reviewboard.kde.org/r/126330/diff/
> 
> 
> Testing
> -------
> 
> Windows.
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151216/866b432f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list