Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

Patrick Spendrin ps_ml at gmx.de
Sun Dec 13 21:57:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126328/
-----------------------------------------------------------

(Updated Dec. 13, 2015, 9:57 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
-------

Submitted with commit da5592e4f50566c33f7bb6da27c32744eca300b8 by Patrick R. Spendrin to branch master.


Repository: kwallet


Description
-------

Strings that are separated into multiple parts don't work on Windows
together with QStringLiteral as the first string is interpreted as a
wide (16bit) string, and the second one as a narrow (8bit) string.
Replacing with QString::fromLatin1 is the easiest solution keeping
the code layout the same, joining the strings does work too though.


Diffs
-----

  src/runtime/kwalletd/kwalletd.cpp 5f99f161a0911732c4d46ab36f2e4f3d3f3e3c4b 

Diff: https://git.reviewboard.kde.org/r/126328/diff/


Testing
-------


Thanks,

Patrick Spendrin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151213/390a959a/attachment.html>


More information about the Kde-frameworks-devel mailing list