Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498

[Emmanuel Pescosta]

> On Dec. 12, 2015, 11:54 a.m., Emmanuel Pescosta wrote:
> > Sorry for breaking this code :/
> > 
> > Would it be possible to add some test cases to prevent such problems in future?
> 
> Xuetian Weng wrote:
>     I don't know. It's not a good practice to test with private interface.

The public methods, which make use of all these private methods as part of their implementation detail, should be tested.

(But I don't know the code, maybe it's impossible to do so.)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126295/#review89378
-----------------------------------------------------------


On Dec. 12, 2015, 12:11 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126295/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2015, 12:11 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Emmanuel Pescosta.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> 9dbe36f734b5b839b2a6a934fad29d639e954498 breaks some assumption on startIndex. The argument index passed to buttonUrl is based number of '/'in full url. Because of that, url like "sftp://a@b.com/a/b" is now shown as "sftp:a at b.com" / "b" / "b" in dolphin url bar.
> 
> This patch changes all relevant code that calls buttonUrl() to use url.path() instead of url.toDisplayString() to count the number of "/".
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kurlnavigator.cpp 848e98b 
> 
> Diff: https://git.reviewboard.kde.org/r/126295/diff/
> 
> 
> Testing
> -------
> 
> Remote url -> ok
> Local url -> ok
> Remote url in places and try browse some sub folder -> ok
> Local url in places and try browse some sub folder -> ok
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151212/52c10791/attachment-0001.html>