Review Request 126295: Fix wrong button in KUrlNavigator issue caused by 9dbe36f734b5b839b2a6a934fad29d639e954498
Xuetian Weng
wengxt at gmail.com
Sat Dec 12 11:11:35 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126295/
-----------------------------------------------------------
(Updated Dec. 12, 2015, 11:11 a.m.)
Review request for KDE Frameworks, David Faure and Emmanuel Pescosta.
Repository: kio
Description
-------
9dbe36f734b5b839b2a6a934fad29d639e954498 breaks some assumption on startIndex. The argument index passed to buttonUrl is based number of '/'in full url. Because of that, url like "sftp://a@b.com/a/b" is now shown as "sftp:a at b.com" / "b" / "b" in dolphin url bar.
This patch changes all relevant code that calls buttonUrl() to use url.path() instead of url.toDisplayString() to count the number of "/".
Diffs (updated)
-----
src/filewidgets/kurlnavigator.cpp 848e98b
Diff: https://git.reviewboard.kde.org/r/126295/diff/
Testing
-------
Remote url -> ok
Local url -> ok
Remote url in places and try browse some sub folder -> ok
Local url in places and try browse some sub folder -> ok
Thanks,
Xuetian Weng
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151212/4f20a1d3/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list