Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123229/#review89297
-----------------------------------------------------------


OK, at least it makes more sense to me now. We register at QCoreApp construction time, even though it's slightly too early (we would want QApp construction time, but no mechanism for that) because doing it earlier is useless. And then we check for QApp in the code. OK.


src/widgets/kdynamicjobtracker.cpp (line 89)
<https://git.reviewboard.kde.org/r/123229/#comment61065>

    this check should also be done on line 76 where another KWidgetJobTracker is being created, then.


- David Faure


On Dec. 7, 2015, 1:29 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123229/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 1:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Prevents the UiDelegate and UiTracker to get initialized, because they'll try to create windows and dialogs when some things happen and these will immediately end in a crash.
> 
> 
> Diffs
> -----
> 
>   src/widgets/kdynamicjobtracker.cpp 14924d5 
> 
> Diff: https://git.reviewboard.kde.org/r/123229/diff/
> 
> 
> Testing
> -------
> 
> Ran the tests, my unit test doesn't crash anymore.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151210/bfb50a74/attachment.html>