Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Dec 9 17:24:01 UTC 2015
> On April 7, 2015, 5:38 p.m., Aleix Pol Gonzalez wrote:
> > src/widgets/jobuidelegate.cpp, line 391
> > <https://git.reviewboard.kde.org/r/123229/diff/2/?file=360351#file360351line391>
> >
> > This is not correct, it's too early to figure out if it's going to have a QApplication or not. Breaks some test.
>
> David Faure wrote:
> Which test? Can you be more specific?
Actually not. I've been trying to reproduce and I really cannot...
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123229/#review78633
-----------------------------------------------------------
On Dec. 7, 2015, 2:29 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123229/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2015, 2:29 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Prevents the UiDelegate and UiTracker to get initialized, because they'll try to create windows and dialogs when some things happen and these will immediately end in a crash.
>
>
> Diffs
> -----
>
> src/widgets/kdynamicjobtracker.cpp 14924d5
>
> Diff: https://git.reviewboard.kde.org/r/123229/diff/
>
>
> Testing
> -------
>
> Ran the tests, my unit test doesn't crash anymore.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151209/7fdd2e90/attachment.html>
More information about the Kde-frameworks-devel
mailing list