Review Request 126038: Add protocol info to KIO plugin metadata

[David Faure]

> On Nov. 12, 2015, 4:12 p.m., Christoph Cullmann wrote:
> > Hi,
> > 
> > I did the same in https://git.reviewboard.kde.org/r/125869/ but I still need to fix the i18n issue, first :/
> 
> Andrew McCann wrote:
>     Ahh, indeed you did.
>     
>     Should I abandon this? or do I 'add' it to yours? somehow.. I'm new to reviewboard.

If what you did is all included in Christoph's request, you can discard this one.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126038/#review88300
-----------------------------------------------------------


On Nov. 12, 2015, 12:59 p.m., Andrew McCann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126038/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 12:59 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Cullmann.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Add protocol info to KIO plugin metadata.  This is necessary to get KDevelop to work on OSX in an app bundle.
> 
> This continues work done by Christoph Cullmann in https://git.reviewboard.kde.org/r/125830/
> 
> Followed the same pattern as the aforementioned diff.
> 
> protocol.json files were generated using the protocoltojson utility.
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/file/file.cpp 381e4885bf0e78ceb4b06f1f1657ad4068923a84 
>   src/ioslaves/file/file.json PRE-CREATION 
>   src/ioslaves/ftp/ftp.cpp 2179179e966d97ce24784292ef67812fa1d3361d 
>   src/ioslaves/ftp/ftp.json PRE-CREATION 
>   src/ioslaves/help/ghelp.json PRE-CREATION 
>   src/ioslaves/help/help.json PRE-CREATION 
>   src/ioslaves/help/main.cpp 9939196b4fc4aefd52c2c13717609181429fe891 
>   src/ioslaves/help/main_ghelp.cpp 59c85587af5edf767261a6b3ca66e6f37efecd29 
>   src/ioslaves/trash/kio_trash.cpp 81cc0361d22606f54d31e6ce743cd5fe818a4701 
>   src/ioslaves/trash/kio_trash_win.cpp 9dd857f3dd9aebaef9e8d9e5adfc30adb0c1ae6b 
>   src/ioslaves/trash/trash.json PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126038/diff/
> 
> 
> Testing
> -------
> 
> With this patch applied, my development version of kdevelop on OSX was able to find:
> (logging statements were added by me, but not in this diff)
> 
> ```
> { Found Plugin path  "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/file.so"
>    protocol contains  "file"
> }
> { Found Plugin path  "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/ftp.so"
>    protocol contains  "ftp"
> }
> { Found Plugin path  "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/ghelp.so"
>    protocol contains  "ghelp"
> }
> { Found Plugin path  "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/help.so"
>    protocol contains  "help"
> }
> { Found Plugin path  "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/http.so"
>    protocol contains  "http"
>    protocol contains  "https"
>    protocol contains  "webdav"
>    protocol contains  "webdavs"
> }
> { Found Plugin path  "/Users/mccann/src/kde_playground/kdevelop_bundle_dest/Applications/kdevelop.app/Contents/PlugIns/kf5/kio/trash.so"
>    protocol contains  "trash"
> }
> ```
> 
> 
> Thanks,
> 
> Andrew McCann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151206/b2264ea7/attachment.html>