Review Request 126245: Cookie dialogue: make Accept/Reject buttons work, and other fixes

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126245/#review89163
-----------------------------------------------------------

Ship it!


Yep, looks 100% correct.

I'm surprised that there are still people using this dialog though, I was considering removing it :-). The default settings (for many years) are to not show this dialog, I assume you change the settings so that it is shown?

- David Faure


On Dec. 4, 2015, 5:16 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126245/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 5:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> The "You received a cookie from..." dialogue appears, but there are a number of things that do not work as intended.  This patch corrects them.
> 
> 1. The first two buttons were presumably intended to be "Accept" and "Reject" as for KDE4, but they actually said "Reject" and "No".  This was a simple cut/paste error.
> 
> 2. Clicking either of these buttons did nothing.  They needed to be connected to accept() and reject() in order to make the exec() called from KCookieServer::checkCookies() return a result.
> 
> 3. The "Set or modify the cookie information" button text was too wide, making the dialogue width far wider than needed for the cookie information.  The dialogue looks better with this changed back to "Details" (with the same icon as for KDE4) with the full text in a tooltip.
> 
> 4. The state of the hide/show details was not being saved correctly.  Using !isHidden() instead of isVisible() gets the correct information.
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/http/kcookiejar/kcookiewin.cpp 56a283f 
> 
> Diff: https://git.reviewboard.kde.org/r/126245/diff/
> 
> 
> Testing
> -------
> 
> Built kio with these changes, checked operation of the cookie dialogue in Konqueror.
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151206/55537d0b/attachment.html>