Review Request 124905: Win: Hide console window for binaries in LIBEXEC

[Kevin Funk]

> On Aug. 27, 2015, 9:57 p.m., Patrick Spendrin wrote:
> > Wait, Wait, Wait.
> > 1) The difference between console apps and GUI apps is that console apps actually have stdin, stdout and stderr streams. So using or not using a console app actually depends on if you need to have these streams!
> > 2) In kde4 (as in standard cmake) the default when you use add_executable is a console application, and if you add WIN32 you'll get a GUI application. In kf5 it was decided that it makes much more sense to mark non-gui applications explicitly, similar to how it is done in qmake (CONFIG += CONSOLE); this is done by the set_target_properties or the ecm macro.
> > About your problem of console windows: there is a different solution for that (it depends on the way the executables are run in QProcess), but I would need to look into the KDE4 code which starts kdeinit4.exe. kdeinit4 *is* a console app.

@Patrick: So what's the proper solution? 

I'd really like to get this fixed. It's a big show-stopper on Windows.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124905/#review84496
-----------------------------------------------------------


On Aug. 27, 2015, 7:31 a.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124905/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2015, 7:31 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry, David Faure, and Boudewijn Rempt.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Win: Hide console window for binaries in LIBEXEC
> 
> 
> Diffs
> -----
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e2800b84c312431cc1996ac81d1ef6fb5cfc 
>   src/ioslaves/http/kcookiejar/CMakeLists.txt 7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365 
>   src/kioexec/CMakeLists.txt 91284a3a61b86770b4d1939da52d256840803608 
>   src/kioslave/CMakeLists.txt e02febd380b268c596e8ecc3b745b6f50993ab4e 
>   src/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc 
> 
> Diff: https://git.reviewboard.kde.org/r/124905/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20151202/4252f55c/attachment.html>