<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124905/">https://git.reviewboard.kde.org/r/124905/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 27th, 2015, 9:57 p.m. UTC, <b>Patrick Spendrin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wait, Wait, Wait.
1) The difference between console apps and GUI apps is that console apps actually have stdin, stdout and stderr streams. So using or not using a console app actually depends on if you need to have these streams!
2) In kde4 (as in standard cmake) the default when you use add_executable is a console application, and if you add WIN32 you'll get a GUI application. In kf5 it was decided that it makes much more sense to mark non-gui applications explicitly, similar to how it is done in qmake (CONFIG += CONSOLE); this is done by the set_target_properties or the ecm macro.
About your problem of console windows: there is a different solution for that (it depends on the way the executables are run in QProcess), but I would need to look into the KDE4 code which starts kdeinit4.exe. kdeinit4 <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">is</em> a console app.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Patrick: So what's the proper solution? </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd really like to get this fixed. It's a big show-stopper on Windows.</p></pre>
<br />
<p>- Kevin</p>
<br />
<p>On August 27th, 2015, 7:31 a.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks, Alex Merry, David Faure, and Boudewijn Rempt.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2015, 7:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Win: Hide console window for binaries in LIBEXEC</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ioslaves/http/CMakeLists.txt <span style="color: grey">(76a8e2800b84c312431cc1996ac81d1ef6fb5cfc)</span></li>
<li>src/ioslaves/http/kcookiejar/CMakeLists.txt <span style="color: grey">(7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365)</span></li>
<li>src/kioexec/CMakeLists.txt <span style="color: grey">(91284a3a61b86770b4d1939da52d256840803608)</span></li>
<li>src/kioslave/CMakeLists.txt <span style="color: grey">(e02febd380b268c596e8ecc3b745b6f50993ab4e)</span></li>
<li>src/kpac/CMakeLists.txt <span style="color: grey">(fc5989714480ca49b5bd72e1c7b458b26bd0d9bc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124905/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>